Additional codes update #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages. Fields reordered.
Noctunus
requested changes
Feb 22, 2024
havan
reviewed
Feb 23, 2024
havan
reviewed
Feb 23, 2024
Co-authored-by: Ekrem Seren <[email protected]>
…avel/camino-messenger-protocol into additional-codes-update
havan
reviewed
Feb 23, 2024
havan
requested changes
Feb 23, 2024
correct Co-authored-by: Ekrem Seren <[email protected]>
correct Co-authored-by: Ekrem Seren <[email protected]>
havan
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of review comments from partners including:
ProductList, ProductInfo and SearchResponse for Accommodation message types, renaming unit_code to supplier_room_code and adding original_room_name.
Explain the requirement for a unique code between ProductList, ProductInfo and SearchResponse to be able to map static and dynamic data correctly. Better explain unit for property, room, mealplan, rateplan logic for multi room/property. Improve documentation of Servicefacts. Adding "Brand" in search.proto (field order changed).