-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 4 update #15
Version 4 update #15
Conversation
…nt, Activity rename ActivityID
…traveller_id for accommodation, activity and transport
…tripsegement in trasport
I will update the code and push to this PR the changes that are simple fixes, typos etc to save time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added multiple comments though out the changes.
proto/cmp/services/activity/v1alpha/search_parameters_types.proto
Outdated
Show resolved
Hide resolved
proto/cmp/services/accommodation/v1alpha/search_result_types.proto
Outdated
Show resolved
Hide resolved
Why between 2 and 18? It can be any positive number and also it can be zero. Am I missing something? |
…mino-messenger-protocol into version-4-update
changed to 0-18 |
proto/cmp/services/activity/v1alpha/search_parameters_types.proto
Outdated
Show resolved
Hide resolved
Co-authored-by: Noc <[email protected]>
Co-authored-by: Noc <[email protected]>
Co-authored-by: Noc <[email protected]>
Co-authored-by: Noc <[email protected]>
…mino-messenger-protocol into version-4-update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Several improvements from reviews: