Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRODUCT-LIST] Add product list service for Activities #3

Merged
merged 2 commits into from
Dec 21, 2023
Merged

[PRODUCT-LIST] Add product list service for Activities #3

merged 2 commits into from
Dec 21, 2023

Conversation

havan
Copy link
Member

@havan havan commented Dec 19, 2023

This PR adds an activity product list service with request/response message types.

SamJaarsma
SamJaarsma requested changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets change bool pickup_ind = 3; to bool pickup_indicator = 3; and add a comment so that it is more clear that a transport to the activity is included or not.

@havan
Copy link
Member Author

havan commented Dec 20, 2023

@SamJaarsma pickup_indicator field is updated.

SamJaarsma
SamJaarsma approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all OK

@havan havan merged commit 43522a2 into dev Dec 21, 2023
6 checks passed
@havan havan deleted the activity-product-list branch December 21, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamJaarsma SamJaarsma SamJaarsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@havan @SamJaarsma