Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FQPN fixes #44

Merged
merged 6 commits into from
Sep 24, 2024
Merged

FQPN fixes #44

merged 6 commits into from
Sep 24, 2024

Conversation

Noctunus
Copy link
Member

@Noctunus Noctunus commented Sep 24, 2024 •
edited
Loading

  • Fixed the FQPN in price_type
  • Added simple script which checks that we use FQPN everywhere.
  • Added fqdn script to the workflow.

This is a breaking change by intention to fix the FQPN for good with this last change to v1.

Fixed the FQPN in price_type. Added simple script which checks that w…
9c3dc7b 
…e use FQPN everywhere. Added fqdn script to the workflow.
SamJaarsma
SamJaarsma approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@SamJaarsma SamJaarsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Noctunus Noctunus merged commit 4742848 into dev Sep 24, 2024
6 of 8 checks passed
@Noctunus Noctunus deleted the FQPN branch September 24, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@havan havan havan approved these changes

@SamJaarsma SamJaarsma SamJaarsma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Noctunus @havan @SamJaarsma