feat(mev-boost): update constraints api #276

namn-grg · 2024-10-07T11:50:06Z

Closes #272

thedevbirb

Looks good! Tried to run it locally and noticed the following:

Failed to send web demo event: Post "http://host.docker.internal:3001/events": dial tcp 198.19.248.254:3001: connect: connection refusedtime="2024-10-07T15:00:26.088Z" level=info msg="sending request for 1 constraint to relay" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=
time="2024-10-07T15:00:26.088Z" level=info msg="sent request for 1 constraint to relay. err = HTTP error response: 400 / Serde decode error: missing field `transactions` at line 1 column 378" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=
time="2024-10-07T15:00:26.088Z" level=warning msg="error calling submitConstraint on relay" error="HTTP error response: 400 / Serde decode error: missing field `transactions` at line 1 column 378" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=
time="2024-10-07T15:00:26.088Z" level=info msg="http: POST /constraints/v1/builder/constraints 502" duration=0.001555 method=POST path=/constraints/v1/builder/constraints status=502 version=
time="2024-10-07T15:00:26.19Z" level=info msg=submitConstraint method=submitConstraint ua=bolt-sidecar version=
time="2024-10-07T15:00:26.19Z" level=info msg="[BOLT]: adding inclusion constraints to cache. slot = 201, validatorPubkey = [171 209 38 120 199 52 99 236 234 88 103 168 12 175 37 109 92 94 107 165 63 241 136 177 67 164 213 190 131 54 90 210 87 237 243 158 170 27 168 117 60 76 223 76 99 47 249 158], number of relays = 1" method=submitConstraint ua=bolt-sidecar version=
time="2024-10-07T15:00:26.19Z" level=info msg="[BOLT]: added inclusion constraints to cache. slot = 201, validatorPubkey = [171 209 38 120 199 52 99 236 234 88 103 168 12 175 37 109 92 94 107 165 63 241 136 177 67 164 213 190 131 54 90 210 87 237 243 158 170 27 168 117 60 76 223 76 99 47 249 158], number of relays = 1" method=submitConstraint ua=bolt-sidecar version=
Failed to send web demo event: Post "http://host.docker.internal:3001/events": dial tcp 198.19.248.254:3001: connect: connection refusedtime="2024-10-07T15:00:26.191Z" level=info msg="sending request for 1 constraint to relay" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=
time="2024-10-07T15:00:26.191Z" level=info msg="sent request for 1 constraint to relay. err = HTTP error response: 400 / Serde decode error: missing field `transactions` at line 1 column 378" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=
time="2024-10-07T15:00:26.191Z" level=warning msg="error calling submitConstraint on relay" error="HTTP error response: 400 / Serde decode error: missing field `transactions` at line 1 column 378" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=

Can you please remove also the web demo logs? It is now deprecated
Validator pubkey isn't displayed well
There is a 400 when sending constraints, we need to check whether this code should change or Helix.

I'm running on the latest unstable commit, therefore consider rebasing as well!

thedevbirb · 2024-10-07T14:54:27Z

mev-boost/server/backend.go

 	pathGetHeader           = "/eth/v1/builder/header/{slot:[0-9]+}/{parent_hash:0x[a-fA-F0-9]+}/{pubkey:0x[a-fA-F0-9]+}"
 	pathGetHeaderWithProofs = "/eth/v1/builder/header_with_proofs/{slot:[0-9]+}/{parent_hash:0x[a-fA-F0-9]+}/{pubkey:0x[a-fA-F0-9]+}"
 	pathGetPayload          = "/eth/v1/builder/blinded_blocks"

+	// Constraints namespace paths


Can you add reference link here?

thedevbirb · 2024-10-07T14:54:45Z

mev-boost/server/constraints.go

+type SignedDelegation struct {
+	Message   Delegation          `json:"message"`
+	Signature phase0.BLSSignature `json:"signature"`
+}
+
+type Delegation struct {
+	ValidatorPubkey phase0.BLSPubKey `json:"validator_pubkey"`
+	DelegateePubkey phase0.BLSPubKey `json:"delegatee_pubkey"`
+}
+
+type SignedRevocation struct {
+	Message   Delegation          `json:"message"`
+	Signature phase0.BLSSignature `json:"signature"`
+}
+
+type Revocation struct {
+	ValidatorPubkey phase0.BLSPubKey `json:"validator_pubkey"`
+	DelegateePubkey phase0.BLSPubKey `json:"delegatee_pubkey"`
+}


Same here for reference links! Thank you

thedevbirb · 2024-10-07T14:56:59Z

mev-boost/server/service.go

+	log.Debug("delegate")
+
+	payload := SignedDelegation{}
+	if err := DecodeJSON(req.Body, &payload); err != nil {
+		m.respondError(w, http.StatusBadRequest, err.Error())
+		return
+	}
+


the log.Debug("delegate") has little utility, perhaps could you print the payload instead?

thedevbirb · 2024-10-07T15:20:20Z

mev-boost/server/constraints.go

+	Pubkey       phase0.BLSPubKey `json:"pubkey"`
+	Slot         uint64           `json:"slot"`
+	Top          bool             `json:"top"`
+	Transactions []Transaction    // Custom marshal and unmarshal implemented below


Suggested change

Transactions []Transaction // Custom marshal and unmarshal implemented below

Transactions []*Transaction `json:"transactions"`

You probably don't need to do additional encoding and decoding here so the concrete transaction type with custom marshal and unmarshal done here https://github.com/chainbound/bolt/blob/naman%2Ffeat%2Fmev-boost%2Fconstraints-api/builder/core/types/constraints.go#L178-L230 is probably not needed.
However you still have to specify the name of the field otherwise the error:

time="2024-10-07T15:00:26.088Z" level=info msg="sent request for 1 constraint to relay. err = HTTP error response: 400 / Serde decode error: missing field `transactions` at line 1 column 378" method=submitConstraint ua=bolt-sidecar url="http://172.16.0.21:4040/constraints/v1/builder/constraints" version=

is thrown

namn-grg · 2024-10-08T14:19:53Z

This should be ready to be merged!

mev-boost/server/service.go

thedevbirb

Great, let's test this e2e and make eventual fixes in other PRs.

merklefruit

PBS flow is working on Kurtosis at latest commit. 🎉

mempirate

LGTM!

namn-grg requested a review from mempirate October 7, 2024 13:31

namn-grg marked this pull request as ready for review October 7, 2024 13:31

thedevbirb reviewed Oct 7, 2024

View reviewed changes

namn-grg force-pushed the naman/feat/mev-boost/constraints-api branch 2 times, most recently from 87bc2d2 to e4e589e Compare October 8, 2024 05:11

thedevbirb force-pushed the naman/feat/mev-boost/constraints-api branch from 0b1225f to 2694da8 Compare October 8, 2024 15:24

thedevbirb reviewed Oct 8, 2024

View reviewed changes

mev-boost/server/service.go Outdated Show resolved Hide resolved

thedevbirb approved these changes Oct 8, 2024

View reviewed changes

merklefruit changed the base branch from unstable to nico/devnet-fix October 9, 2024 17:46

namn-grg and others added 11 commits October 9, 2024 19:47

feat(mev-boost): update ConstraintMessage

cb72c20

feat(mev-boost): add delegate, revoke

7c77455

feat(mev-boost): versioned signed builder bid

d678b3f

fix(mev-boost): mock relay - rm bid with inclusion proof

6578337

misc(mev-boost): address review

8074c7d

chore(mev-boost): rm bolt demo events

53579f6

fix(mev-boost): pubkey log display

4a675c9

test(mev-boost): add logs, nits

ea2f6b1

chore(mev-boost): unmarshal json builder bid with proof

ed3af99

test(mev-boost): delegation revocation

b09363b

Update mev-boost/server/service.go

eb47e26

merklefruit force-pushed the naman/feat/mev-boost/constraints-api branch from 3d8123e to eb47e26 Compare October 9, 2024 17:47

merklefruit approved these changes Oct 9, 2024

View reviewed changes

mempirate approved these changes Oct 10, 2024

View reviewed changes

thedevbirb approved these changes Oct 10, 2024

View reviewed changes

thedevbirb merged commit b9b38f1 into nico/devnet-fix Oct 10, 2024
3 checks passed

thedevbirb deleted the naman/feat/mev-boost/constraints-api branch October 10, 2024 08:40

This was referenced Oct 10, 2024

fix: updated devnet #285

Merged

Update constraints-API in mev-boost #272

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mev-boost): update constraints api #276

feat(mev-boost): update constraints api #276

namn-grg commented Oct 7, 2024

thedevbirb left a comment •

edited

Loading

thedevbirb Oct 7, 2024

thedevbirb Oct 7, 2024

thedevbirb Oct 7, 2024

thedevbirb Oct 7, 2024

namn-grg commented Oct 8, 2024

thedevbirb left a comment

merklefruit left a comment

mempirate left a comment

	Transactions []Transaction // Custom marshal and unmarshal implemented below
	Transactions []*Transaction `json:"transactions"`

feat(mev-boost): update constraints api #276

feat(mev-boost): update constraints api #276

Conversation

namn-grg commented Oct 7, 2024

thedevbirb left a comment • edited Loading

Choose a reason for hiding this comment

thedevbirb Oct 7, 2024

Choose a reason for hiding this comment

thedevbirb Oct 7, 2024

Choose a reason for hiding this comment

thedevbirb Oct 7, 2024

Choose a reason for hiding this comment

thedevbirb Oct 7, 2024

Choose a reason for hiding this comment

namn-grg commented Oct 8, 2024

thedevbirb left a comment

Choose a reason for hiding this comment

merklefruit left a comment

Choose a reason for hiding this comment

mempirate left a comment

Choose a reason for hiding this comment

thedevbirb left a comment •

edited

Loading