feat(sidecar): sign messages using the correct signing domain #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merklefruit
commented
Oct 7, 2024
Comment on lines
-112
to
+116
| async fn sign(&self, data: &[u8; 32]) -> eyre::Result<BlsSignature> { | ||
| let request = SignConsensusRequest::builder( | ||
| *self.pubkeys.read().first().expect("consensus pubkey loaded"), | ||
| ) | ||
| .with_msg(data); | ||
| async fn sign_commit_boost_root(&self, data: &[u8; 32]) -> eyre::Result<BlsSignature> { | ||
| let request = SignConsensusRequest { | ||
| pubkey: *self.pubkeys.read().first().expect("consensus pubkey loaded"), | ||
| object_root: *data, | ||
| }; |
There was a problem hiding this comment.
with_msg() was calling tree_hash_root() internally. Since we already have a 32 bytes message, we don't need to do this. If a tree hash root is required, it must be hashed by the caller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signing and verifying messages with BLS keys now complies to the consensus-layer signing domains spec.
In particular, two signing domains are provided:
APPLICATION_BUILDERandCOMMIT_BOOST.Signers are able to sign() or verify() messages in both domains explicitly to avoid incurring in inconsistencies.
Note: the beacon-chain specs also define signing over SSZ containers via hash_tree_root. We currently don't do that, and have decided to use our own signing digests that are simpler and don't require deriving SSZ. Since this is an out-of-protocol API we are not required to comply to this restriction.