Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidecar): add commitment signing key + holesky deployment scripts #301

Merged
merged 9 commits into from
Oct 18, 2024

Conversation

merklefruit
Copy link
Collaborator

@merklefruit merklefruit commented Oct 18, 2024

@merklefruit merklefruit changed the title feat(sidecar): add default secrets folder for ERC-2335 keystore feat(sidecar): add commitment signing key + holesky deployment scripts Oct 18, 2024
@merklefruit merklefruit marked this pull request as ready for review October 18, 2024 12:53
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, some minor things

bolt-sidecar/src/config/constraint_signing.rs Outdated Show resolved Hide resolved
bolt-sidecar/src/config/mod.rs Outdated Show resolved Hide resolved
bolt-sidecar/src/config/mod.rs Outdated Show resolved Hide resolved
bolt-sidecar/src/driver.rs Outdated Show resolved Hide resolved
justfile Outdated Show resolved Hide resolved
@thedevbirb thedevbirb merged commit e919dc2 into lore/feat/keystore-secrets Oct 18, 2024
3 checks passed
@thedevbirb thedevbirb deleted the nico/chore/commitment-key branch October 18, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants