Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for working directory per step #19

Conversation

stormqueen1990
Copy link
Contributor

Add support to specify a working directory per step of the test. This plumbs the working directory through to the container runtime for the exec operation.

@joshrwolf
Copy link
Collaborator

this is great! I think the semantics and signature of the StepConfig() will need to change when we're not as lucky with the null values plumbing, but lets not over optimize here 🙏

you're just missing a go generate ./... and this is g2g!

Mauren Berti added 2 commits January 29, 2024 13:28
Add support to specify a working directory per step of the test. This plumbs
the working directory through to the container runtime for the exec operation.

Signed-off-by: Mauren Berti <[email protected]>
Signed-off-by: Mauren Berti <[email protected]>
@stormqueen1990 stormqueen1990 force-pushed the feat/workdir-for-container-harness branch from 5be3df9 to ce033e0 Compare January 29, 2024 18:28
@stormqueen1990 stormqueen1990 changed the title [WIP] feat: add support for working directory per step feat: add support for working directory per step Jan 29, 2024
@stormqueen1990 stormqueen1990 marked this pull request as ready for review January 29, 2024 18:29
@joshrwolf joshrwolf merged commit e70f0fa into chainguard-dev:main Jan 29, 2024
5 checks passed
@stormqueen1990 stormqueen1990 deleted the feat/workdir-for-container-harness branch January 29, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants