Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iterators to parse da_data into sequencer commitments #1457

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

yaziciahmet
Copy link
Contributor

@yaziciahmet yaziciahmet commented Nov 11, 2024

Description

Use iterators to parse da_data into sequencer commitments. Reasons:

  1. Iterators are more idiomatic to Rust.
  2. Rust compiler is able to optimize chained iterators more efficiently.

Linked Issues

  • Fixes # (issue, if applicable)
  • Related to # (issue)

Testing

Describe how these changes were tested. If you've added new features, have you added unit tests?

Docs

Describe where this code is documented. If it changes a documented interface, have the docs been updated?

@yaziciahmet yaziciahmet changed the title Zero vec allocation sequencer commitments in zk Less vec allocation sequencer commitments in zk Nov 11, 2024
@yaziciahmet yaziciahmet changed the title Less vec allocation sequencer commitments in zk Use iterators to parse da_data into sequencer commitments Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 75.8%. Comparing base (79eb7c6) to head (ad7fc9d).
Report is 2 commits behind head on nightly.

Files with missing lines Patch % Lines
...module-system/sov-modules-stf-blueprint/src/lib.rs 0.0% 12 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...module-system/sov-modules-stf-blueprint/src/lib.rs 43.8% <0.0%> (-2.6%) ⬇️

... and 2 files with indirect coverage changes

@eyusufatik eyusufatik merged commit 1a40a29 into nightly Nov 11, 2024
13 of 14 checks passed
@eyusufatik eyusufatik deleted the yaziciahmet/zero-vec-alloc-commitments-in-zk branch November 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants