Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ethers dependency on system txs #436

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

eyusufatik
Copy link
Member

@eyusufatik eyusufatik commented Apr 24, 2024

Description

Removes dependency on ethers in system transactions module. This is helpful for batch proving

This is a part of #329

@eyusufatik eyusufatik requested a review from kpp April 24, 2024 09:37
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.4%. Comparing base (ecc847c) to head (77e9da8).
Report is 1 commits behind head on nightly.

Additional details and impacted files
Files Coverage Δ
crates/evm/src/evm/system_contracts/mod.rs 100.0% <100.0%> (ø)
crates/evm/src/evm/system_events.rs 98.0% <100.0%> (-0.2%) ⬇️

... and 2 files with indirect coverage changes

@eyusufatik eyusufatik merged commit 51c1e8e into nightly Apr 24, 2024
8 checks passed
@eyusufatik eyusufatik deleted the esad/sys-tx-dont-use-ethers branch April 24, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants