Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix invalid self-closing tags to proper closing tags f… #2012

Merged

Conversation

babakfp
Copy link
Contributor

@babakfp babakfp commented Nov 5, 2024

…or Svelte 5

📝 Description

Something like <div /> is invalid now in Svelte 5.

sveltejs/svelte#11052

💣 Is this a breaking change (Yes/No):

No.

Copy link

changeset-bot bot commented Nov 5, 2024

⚠️ No Changeset found

Latest commit: 0362553

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
zag-solid ✅ Ready (Inspect) Visit Preview Nov 5, 2024 5:24pm
zag-svelte ✅ Ready (Inspect) Visit Preview Nov 5, 2024 5:24pm
zag-vue ✅ Ready (Inspect) Visit Preview Nov 5, 2024 5:24pm
zag-website ✅ Ready (Inspect) Visit Preview Nov 5, 2024 5:24pm

Copy link

vercel bot commented Nov 5, 2024

@babakfp is attempting to deploy a commit to the Chakra UI Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

pkg-pr-new bot commented Nov 5, 2024

Open in Stackblitz

@zag-js/anatomy

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/anatomy@2012

@zag-js/anatomy-icons

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/anatomy-icons@2012

@zag-js/docs

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/docs@2012

@zag-js/core

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/core@2012

@zag-js/store

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/store@2012

@zag-js/types

pnpm add https://pkg.pr.new/chakra-ui/zag/@zag-js/types@2012

commit: 0362553

@segunadebayo segunadebayo merged commit 5fba0e3 into chakra-ui:main Nov 6, 2024
21 of 22 checks passed
@babakfp babakfp deleted the svelte_5_invalid_selfclosing_tags branch November 6, 2024 22:42
segunadebayo pushed a commit that referenced this pull request Nov 10, 2024
fix(docs): convert invalid self-closing tags to proper closing tags for Svelte 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants