Minigrid Setup #326
Closed
Minigrid Setup #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapatil211
requested changes
Feb 22, 2023
|
This should be merged after #272 , since that has the support for environment wrappers. Once that's there, you should delete the MiniGridEnv class, and just register the minigrid wrappers, with names like 'minigrid.FullyObsWrapper'. |
|
@mrsamsami #272 is now merged, so can you update this PR? |
dapatil211
requested changes
May 19, 2023
Comment on lines
+4
to
+10
| from minigrid import ( | ||
| FlatObsWrapper, | ||
| FullyObsWrapper, | ||
| ImgObsWrapper, | ||
| RGBImgObsWrapper, | ||
| RGBImgPartialObsWrapper, | ||
| ) |
There was a problem hiding this comment.
Can you update with changes from dev branch and move these changes to gym/gym_wrappers.py, inside of a try block?
Like:
try:
importing and registering minigrid wrappers
except:
...
Comment on lines
+33
to
+37
| "minigrid.FullyObsWrapper": FullyObsWrapper, | ||
| "minigrid.FlatObsWrapper": FlatObsWrapper, | ||
| "minigrid.ImgObsWrapper": ImgObsWrapper, | ||
| "minigrid.RGBImgObsWrapper": RGBImgObsWrapper, | ||
| "minigrid.RGBImgPartialObsWrapper": RGBImgPartialObsWrapper, |
There was a problem hiding this comment.
These should be registered as gymwrappers and not environments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.