Enhance bezier-vscode pacakge
#2485
Assignees
Labels
bezier-vscode
Issue or PR related to bezier-vscode
epic
Issue consisting of multiple issues of the same purpose
Comments
yangwooseong
added
epic
6 tasks
yangwooseong
added a commit
that referenced
this issue
Nov 7, 2024
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> - #2485 ## Summary <!-- Please brief explanation of the changes made --> - `bezier-vscode` 익스텐션의 자동완성 로직을 아래와 같이 변경합니다. ## Details <!-- Please elaborate description of the changes --> - 바꾸는 이유는 이슈를 참고해주세요. As-is https://github.com/user-attachments/assets/617d5872-ef8d-4613-aad4-3f6f5471d480 To-be https://github.com/user-attachments/assets/fe146de3-2aa5-47b1-88b7-f4b03b23a9e1 ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> - No ## References <!-- Please list any other resources or points the reviewer should be aware of --> - None
This was referenced Nov 12, 2024
yangwooseong
added a commit
that referenced
this issue
Nov 12, 2024
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> - #2485 ## Summary <!-- Please brief explanation of the changes made --> - alpha 토큰도 자동완성 추천에 나오도록 합니다. ## Details <!-- Please elaborate description of the changes --> - legacy token, alpha token 별로 `{ category: { [name]: value }` 객체를 assignToTokenMap 함수를 통해 만든 다음에 딥 머지를 했습니다. 이 때 alpha token의 "dimension" category 는 바뀔 예정이라 제외했습니다. https://github.com/user-attachments/assets/6c14d51c-9e44-4de7-92c9-419cf933959e ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> - No ## References <!-- Please list any other resources or points the reviewer should be aware of --> - None
yangwooseong
added a commit
that referenced
this issue
Nov 14, 2024
<!-- How to write a good PR title: - Follow [the Conventional Commits specification](https://www.conventionalcommits.org/en/v1.0.0/). - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ## Self Checklist - [x] I wrote a PR title in **English** and added an appropriate **label** to the PR. - [x] I wrote the commit message in **English** and to follow [**the Conventional Commits specification**](https://www.conventionalcommits.org/en/v1.0.0/). - [x] I [added the **changeset**](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md) about the changes that needed to be released. (or didn't have to) - [x] I wrote or updated **documentation** related to the changes. (or didn't have to) - [x] I wrote or updated **tests** related to the changes. (or didn't have to) - [x] I tested the changes in various browsers. (or didn't have to) - Windows: Chrome, Edge, (Optional) Firefox - macOS: Chrome, Edge, Safari, (Optional) Firefox ## Related Issue <!-- Please link to issue if one exists --> <!-- Fixes #0000 --> - #2485 ## Summary <!-- Please brief explanation of the changes made --> - `bezier-vscode` 배포를 release.yml 에 추가해서 changesets PR을 머지하면 자동으로 배포되도록 합니다. - 누락된 LICENSE 파일을 추가합니다. 이게 없으니 `vsce publish`실행시키면 `그대로 진행하시곘습니까? [y/N]` 을 물어보네요. ## Details <!-- Please elaborate description of the changes --> - `VSCE_PAT`: VSCode 퍼블리셔의 [토큰입니다](https://www.notion.so/channelio/42644061d7f542a9bf5684f2807128e4?pvs=4#c7f90fd0ef95446c84bf25f335cb97cc). 레포 시크릿에 추가헀습니다. - `--no-dependencies`: yarn 버전 이슈때문에 안넣어주면 에러가 뜹니다 (microsoft/vscode-vsce#517) - `continue-on-error`: changesets PR 에 VSCode 관련 변경 사항이 없을 경우에 현재 배포된 버전과 같은 버전으로 배포하게 되는데 이때 워닝이 아니라 에러를 뱉기 떄문에 true 로 했습니다. - https://github.com/channel-io/bezier-react/pull/2496/files 이 PR이 머지되면 0.3.0 으로 버전이 올라간채로 changesets PR이 만들어지기 때문에, 그 전에 0.2.0 배포하고나서 changesets PR을 머지해서 0.3.0을 배포하도록 해야할 것 같네요. ### Breaking change? (Yes/No) <!-- If Yes, please describe the impact and migration path for users --> - No ## References <!-- Please list any other resources or points the reviewer should be aware of --> - https://www.eliostruyf.com/publishing-vscode-extensions-github-actions/ - `vsce publish --help`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Description
var(--bgtxt-black-dark)를 입력하기 위해var를 입력하고,bg...를 입력하면 자동완성 리스트가 뜹니다.--로는 VS Code가 자동완성 매칭을 해주고 있지 않아서 이렇게 개발했지만, 사용자 입장에서는var입력 후--가 아닌bg를 입력해야 한다는 것이 다소 직관적이지 않습니다.bg만 입력해도 자동완성 리스트가 뜨고, 탭 키로 완성하면var(--bgtxt-black-dark)가 삽입되는 형태로 개선하면 좋겠습니다.2024-11-07.11.27.52.mov
bezier-vscodemetadata for publish #2153 (review)Tasks
References
The text was updated successfully, but these errors were encountered: