Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change autocomplete logic of bezier-vscode #2486

Merged

Conversation

yangwooseong
Copy link
Collaborator

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

  • bezier-vscode 익스텐션의 자동완성 로직을 아래와 같이 변경합니다.

Details

  • 바꾸는 이유는 이슈를 참고해주세요.

As-is

2024-11-07.11.27.52.mov

To-be

2024-11-07.4.32.05.mov

Breaking change? (Yes/No)

  • No

References

  • None

@yangwooseong yangwooseong added enhancement Issues or PR related to making existing features better bezier-vscode Issue or PR related to bezier-vscode labels Nov 7, 2024
@yangwooseong yangwooseong self-assigned this Nov 7, 2024
Copy link

channeltalk bot commented Nov 7, 2024

Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: 5b6c2a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bezier-vscode Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (1afe04b) to head (5b6c2a5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2486   +/-   ##
=======================================
  Coverage   82.27%   82.27%           
=======================================
  Files         143      143           
  Lines        2979     2979           
  Branches      913      917    +4     
=======================================
  Hits         2451     2451           
  Misses        497      497           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sungik-choi sungik-choi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

@yangwooseong yangwooseong merged commit ed78943 into channel-io:main Nov 7, 2024
5 checks passed
@yangwooseong yangwooseong deleted the WEB-5280/vscode-autocomplete-logic branch November 7, 2024 08:27
yangwooseong pushed a commit that referenced this pull request Nov 11, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/[email protected]

### Minor Changes

- Layout components support the `basis` (`flex-basis`) property.
([#2495](#2495)) by
@sungik-choi

### Patch Changes

- Improve the rendering performance of components that use `LegacyIcon`.
([#2494](#2494)) by
@sungik-choi

## [email protected]

### Minor Changes

- Change autocomplete logic. Now token name can trigger autocomplete
even without `var` string.
([#2486](#2486)) by
@yangwooseong

## [email protected]

### Patch Changes

-   Updated dependencies
    -   @channel.io/[email protected]

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bezier-vscode Issue or PR related to bezier-vscode enhancement Issues or PR related to making existing features better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants