Updates #101
Merged
Updates #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make it more obvious what's happening when running commands.
ahuth
commented
Sep 23, 2024
| "prepublishOnly": "npm run build", | ||
| "pretest:integration": "npm run build && npm run demo:build", |
There was a problem hiding this comment.
I removed the pre scripts, to make it more clear what's happening when running something like npm run integration
ahuth
commented
Sep 23, 2024
| @@ -51,7 +51,7 @@ it('accepts a port to run on', () => { | |||
|
|
|||
| return new Promise<void>((done) => { | |||
| exec( | |||
| 'cd demo && npm run storybook:axeOnly -- --port 8111', | |||
| 'cd demo && npm run storybook:axeOnly -- --port 8112', | |||
There was a problem hiding this comment.
Changed the port because it turns out Chrome is already using 8111 (at least on my machine).
Per vitest-dev/eslint-plugin-vitest#537. Also resolves some peer deps issues.
ahuth
commented
Sep 23, 2024
| @@ -1,5 +1,3 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Updated lint rule config, and these imports are no longer needed.
ahuth
commented
Sep 23, 2024
| import typescriptEslint from 'typescript-eslint'; | ||
|
|
||
| /** @type {import("eslint").Linter.Config[]} */ | ||
| export default [ |
There was a problem hiding this comment.
Converted to ESM config file
timzchang
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates