Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] add support for managing tfe providers #456

Merged
merged 5 commits into from
Apr 10, 2020
Merged

[feature] add support for managing tfe providers #456

merged 5 commits into from
Apr 10, 2020

Conversation

ryanking
Copy link
Contributor

@ryanking ryanking commented Apr 9, 2020 •
edited
Loading

Test Plan

  • CI
  • manually tested on 1 internal repo

References

@ryanking ryanking marked this pull request as ready for review April 9, 2020 23:22
@ryanking ryanking requested a review from a team as a code owner April 9, 2020 23:22
@ryanking ryanking requested a review from jgadling April 9, 2020 23:22
@codecov-io
Copy link

codecov-io commented Apr 9, 2020 •
edited
Loading

Codecov Report

Merging #456 into master will decrease coverage by 0.44%.
The diff coverage is 29.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #456      +/-   ##
==========================================
- Coverage   61.49%   61.05%   -0.45%     
==========================================
  Files          19       19              
  Lines        1896     1923      +27     
==========================================
+ Hits         1166     1174       +8     
- Misses        579      598      +19     
  Partials      151      151
Impacted Files Coverage Δ
config/v2/config.go 9.48% <ø> (ø)
config/v2/resolvers.go 57.86% <0.00%> (-3.09%) ⬇️
plan/plan.go 84.66% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec24ae0...5b9053d. Read the comment docs.

edulop91
edulop91 reviewed Apr 10, 2020
View reviewed changes
plan/plan_test.go Outdated Show resolved Hide resolved
@ryanking ryanking mentioned this pull request Apr 10, 2020
Open
@czimergebot czimergebot merged commit dd1c7ec into master Apr 10, 2020
@czimergebot czimergebot deleted the ryanking/tfe-provider branch April 10, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edulop91 edulop91 edulop91 approved these changes

@jgadling jgadling jgadling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanking @codecov-io @jgadling @edulop91 @czimergebot