Update periodic hills example #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsaavedra
added
Ready for review
Example
Next release
blaisb
requested changes
Nov 11, 2024
| set ilu preconditioner relative tolerance = 1.00 | ||
| set verbosity = verbose | ||
| set method = gmres | ||
| set max iters = 5000 |
There was a problem hiding this comment.
Do we need such a large amount of iterations by default?
| set max iters = 5000 | ||
| set relative residual = 1e-3 | ||
| set minimum residual = 1e-9 | ||
| set max krylov vectors = 200 |
There was a problem hiding this comment.
Maybe we could lower the amount of iterations and increase the max number of krylov vectors to match it?
There was a problem hiding this comment.
Yes, I think this is a good idea. I have checked the output files, and I think 300 would be reasonable for both.
lpsaavedra
force-pushed
the
review_periodic_hills
branch
from
8a7e05a
to
a05c2c7
Compare
blaisb
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A useless warning for the output folder was removed and the default parameters of the ILU preconditioner were removed from the prm file. Apart from this, the example is up to date and everything works as expected.
Checklist (will be removed when merged)
See this page for more information about the pull request process.
Code related list:
Pull request related list: