chaosblade website contribution #167
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yangchuankun <[email protected]>
✅ Deploy Preview for chaosblade ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sunny0826
requested changes
Oct 22, 2023
Comment on lines
+90
to
+95
| ## 第五步：PR审查直至审查通过 | ||
|
|
||
|  | ||
|
|
||
|
|
||
| ## 第六步：PR合并至master，新增官网文档贡献成功 |
There was a problem hiding this comment.
这里需要新增一个步骤，提交 PR 后，会自动生成 preview 链接，需要先自行 review 并确实提交文档的样式与内容无误。之后才会有有 maintainer 进行 review
Comment on lines
+96
to
+99
| ### 6.1 PR合并完成 | ||
|
|
||
|  | ||
|
|
There was a problem hiding this comment.
请添加 maintainer 的 review 的步骤，并不是所有 PR 最终都会被合并
|
@bernersyang 请根据 Review 内容修改 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChaosBlade Project Guide: How to Contribute official website Documents to the Community