Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _form.html.haml #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update _form.html.haml #126

wants to merge 1 commit into from

Conversation

derlucas
Copy link

@derlucas derlucas commented Oct 6, 2022

removed the price disabled flag since it's annoying. A user can delete items without consent, but not change the price?

removed the price disabled flag since it's annoying. A user can delete items without consent, but not change the price?
@YtvwlD
Copy link
Member

YtvwlD commented Oct 15, 2022

Thanks for the input. The discrepancy between "everyone is able to delete drinks" and "noone is able to modify drinks" has been bugging me for a while.

The code looks good so far, but I'm unsure about the policy behind this.

Could you please

  • open a new PR removing the button for the drink deletion?
  • add a new commit to this PR (or open a new PR) adding a audit log for changes to drinks?

Thanks for your effort!

@YtvwlD YtvwlD mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants