Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Release to Main #2665

Merged
merged 155 commits into from
Feb 13, 2024
Merged

Dev Release to Main #2665

merged 155 commits into from
Feb 13, 2024

Conversation

sgoggins
Copy link
Member

Description

  • Release Dev to Main
    Updating our release strategy to release more often.

Seltyk and others added 30 commits August 7, 2023 16:18
Also wrote API documentation for it using an
example 3scale repo in my testing

Signed-off-by: Seltyk <[email protected]>
I'm honestly not sure why "object" doesn't work
out, so for the first time in my life, I had to
write docs for the docs in the docs!

Signed-off-by: Seltyk <[email protected]>
Bumps [tornado](https://github.com/tornadoweb/tornado) from 6.1 to 6.3.3.
- [Changelog](https://github.com/tornadoweb/tornado/blob/master/docs/releases.rst)
- [Commits](tornadoweb/tornado@v6.1.0...v6.3.3)

---
updated-dependencies:
- dependency-name: tornado
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [joblib](https://github.com/joblib/joblib) from 1.0.1 to 1.2.0.
- [Release notes](https://github.com/joblib/joblib/releases)
- [Changelog](https://github.com/joblib/joblib/blob/master/CHANGES.rst)
- [Commits](joblib/joblib@1.0.1...1.2.0)

---
updated-dependencies:
- dependency-name: joblib
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scipy](https://github.com/scipy/scipy) from 1.7.3 to 1.10.0.
- [Release notes](https://github.com/scipy/scipy/releases)
- [Commits](scipy/scipy@v1.7.3...v1.10.0)

---
updated-dependencies:
- dependency-name: scipy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scipy](https://github.com/scipy/scipy) from 1.7.3 to 1.10.0.
- [Release notes](https://github.com/scipy/scipy/releases)
- [Commits](scipy/scipy@v1.7.3...v1.10.0)

---
updated-dependencies:
- dependency-name: scipy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scipy](https://github.com/scipy/scipy) from 1.7.3 to 1.10.0.
- [Release notes](https://github.com/scipy/scipy/releases)
- [Commits](scipy/scipy@v1.7.3...v1.10.0)

---
updated-dependencies:
- dependency-name: scipy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [scipy](https://github.com/scipy/scipy) from 1.7.3 to 1.10.0.
- [Release notes](https://github.com/scipy/scipy/releases)
- [Commits](scipy/scipy@v1.7.3...v1.10.0)

---
updated-dependencies:
- dependency-name: scipy
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…analysis/pull_request_analysis_worker/scipy-1.10.0

Bump scipy from 1.7.3 to 1.10.0 in /augur/tasks/data_analysis/pull_request_analysis_worker
…analysis/discourse_analysis/scipy-1.10.0

Bump scipy from 1.7.3 to 1.10.0 in /augur/tasks/data_analysis/discourse_analysis
…analysis/message_insights/joblib-1.2.0

Bump joblib from 1.0.1 to 1.2.0 in /augur/tasks/data_analysis/message_insights
…analysis/message_insights/scipy-1.10.0

Bump scipy from 1.7.3 to 1.10.0 in /augur/tasks/data_analysis/message_insights
Signed-off-by: Andrew Brain <[email protected]>
Co-authored-by: John McGinness <[email protected]>
Update repo load controller with orm syntax
UPdate dependabot branch with updates to dev
Fix issue when merging repo_load_controller changes and orm warning changes together
updating dev-dependabot with dev changes
Dependabot updates: Validated in Production
sgoggins and others added 3 commits January 26, 2024 12:30
@sgoggins sgoggins requested a review from IsaacMilarky January 26, 2024 18:45
Updating materialized view branch with latest dev changes
IsaacMilarky
IsaacMilarky previously approved these changes Jan 26, 2024
Copy link
Contributor

@IsaacMilarky IsaacMilarky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to merge

@@ -132,9 +132,10 @@ def get_required_conditions_for_ml_repos(allow_collected_before = False, days_un


class CollectionRequest:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

̶W̶e̶ ̶s̶h̶o̶u̶l̶d̶ ̶p̶r̶o̶b̶a̶b̶l̶y̶ ̶c̶h̶a̶n̶g̶e̶ ̶t̶h̶i̶s̶ ̶i̶n̶t̶o̶ ̶s̶o̶m̶e̶ ̶k̶i̶n̶d̶ ̶o̶f̶ ̶s̶e̶p̶a̶r̶a̶t̶e̶d̶ ̶c̶l̶a̶s̶s̶ ̶s̶t̶r̶u̶c̶t̶u̶r̶e̶ ̶w̶h̶e̶r̶e̶ ̶w̶e̶ ̶h̶a̶v̶e̶ ̶a̶ ̶̶G̶i̶t̶H̶u̶b̶C̶o̶l̶l̶e̶c̶t̶i̶o̶n̶R̶e̶q̶u̶e̶s̶t̶̶ ̶a̶n̶d̶ ̶a̶ ̶̶G̶i̶t̶L̶a̶b̶C̶o̶l̶l̶e̶c̶t̶i̶o̶n̶R̶e̶q̶u̶e̶s̶t̶̶ ̶l̶a̶t̶e̶r̶ ̶b̶u̶t̶ ̶I̶ ̶t̶h̶i̶n̶k̶ ̶i̶t̶'̶s̶ ̶f̶i̶n̶e̶ ̶f̶o̶r̶ ̶n̶o̶w̶.̶

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although, that might complicate our fairness algorithm since we treat GitHub and GitLab equally and it makes sense to mix them together in a CollectionRequest. Instead what we should do is use some kind of mapping logic so that the CollectionRequest can detect the platform of the repo and map it similar to this example.

sgoggins and others added 4 commits January 26, 2024 16:03
Added indexes to materialized views missing indexes.

Updated materialized view refresh script.
sgoggins and others added 2 commits January 30, 2024 12:06
Updating materialized view refresh branch patch
IsaacMilarky
IsaacMilarky previously approved these changes Feb 6, 2024
Copy link
Contributor

@IsaacMilarky IsaacMilarky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get this merged sooner rather than later

sgoggins and others added 2 commits February 8, 2024 16:01
Signed-off-by: Sean Goggins <seangoggins@[email protected]>
@IsaacMilarky
Copy link
Contributor

Testing dev today I ran into issues using the cli. It wasn't recognizing the server subcommand so I couldn't run collection on macOS. It might be a mac issue but I can't verify that at the moment.

Signed-off-by: Sean P. Goggins <[email protected]>
docker compose mounts volume for postgres by default
@sgoggins
Copy link
Member Author

Testing dev today I ran into issues using the cli. It wasn't recognizing the server subcommand so I couldn't run collection on macOS. It might be a mac issue but I can't verify that at the moment.

Do you mean the backend command?

@IsaacMilarky
Copy link
Contributor

IsaacMilarky commented Feb 12, 2024

Do you mean the backend command?

I did not see that command being recognized either. I was also able to replicate this problem on my linux machine. It seems that only a fraction of the subcommands are being recognized.
Screenshot_20240212_104129

Materialized View Update Updates
@@ -125,7 +145,40 @@ def refresh_materialized_views():
logger.info(f"error is {e}")
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)

session.execute_sql(mv9_refresh)
except Exception as e:
logger.info(f"error is {e}")
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)

session.execute_sql(mv10_refresh)
except Exception as e:
logger.info(f"error is {e}")
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)

session.execute_sql(mv11_refresh)
except Exception as e:
logger.info(f"error is {e}")
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)

session.execute_sql(mv12_refresh)
except Exception as e:
logger.info(f"error is {e}")
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)

session.execute_sql(mv13_refresh)
except Exception as e:
logger.info(f"error is {e}")
pass

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[pylint] reported by reviewdog 🐶
W0107: Unnecessary pass statement (unnecessary-pass)

Copy link
Member Author

@sgoggins sgoggins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be resolving the pylint reqeusts for docstrings as they occur in our PRs to slowly address this?

@IsaacMilarky
Copy link
Contributor

Do you mean the backend command?

I did not see that command being recognized either. I was also able to replicate this problem on my linux machine. It seems that only a fraction of the subcommands are being recognized. Screenshot_20240212_104129

Ok it seems this wasn't an issue with dev and was an unrelated typo on a different branch. Nevermind sorry!

@sgoggins sgoggins merged commit 788b75c into main Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants