Fix a few small collection issues

augur/tasks/github/messages/tasks.py

@@ -1,11 +1,11 @@
 import time
 import logging
 
 import traceback
 
 from augur.tasks.init.celery_app import celery_app as celery
 from augur.tasks.init.celery_app import AugurCoreRepoCollectionTask
 from augur.application.db.data_parse import *
 from augur.tasks.github.util.github_paginator import GithubPaginator, hit_api
 from augur.tasks.github.util.github_task_session import GithubTaskManifest
 from augur.application.db.session import DatabaseSession
@@ -20,7 +20,7 @@
 
 
 @celery.task(base=AugurCoreRepoCollectionTask)
 def collect_github_messages(repo_git: str) -> None:
 
     logger = logging.getLogger(collect_github_messages.__name__)
 
@@ -44,7 +44,7 @@
 
 
 
 def retrieve_all_pr_and_issue_messages(repo_git: str, logger, key_auth, task_name) -> None:
 
     owner, repo = get_owner_repo(repo_git)
 
@@ -66,7 +66,7 @@
     all_data = []
     for page_data, page in messages.iter_pages():
 
         if page_data is None:
             return all_data
 
         elif len(page_data) == 0:
@@ -83,7 +83,7 @@
     return all_data
 
 
 def process_messages(messages, task_name, repo_id, logger, augur_db):
 
     tool_source = "Pr comment task"
     tool_version = "2.0"
@@ -187,7 +187,8 @@
     message_string_fields = ["msg_text"]
     message_return_data = augur_db.insert_data(message_dicts, Message, message_natural_keys, 
                                                 return_columns=message_return_columns, string_fields=message_string_fields)
-
+    if message_return_data is None:
+        return
 
     pr_message_ref_dicts = []
     issue_message_ref_dicts = []
@@ -216,7 +217,7 @@
     logger.info(f"{task_name}: Inserted {len(message_dicts)} messages. {len(issue_message_ref_dicts)} from issues and {len(pr_message_ref_dicts)} from prs")
 
 
 def is_issue_message(html_url):
 
     return '/pull/' not in html_url
 

augur/tasks/github/releases/core.py

@@ -84,7 +84,8 @@ def insert_release(augur_db, logger, repo_id, owner, release, tag_only = False):
     release_inf = get_release_inf(repo_id, release, tag_only)
 
     #Do an upsert
-    augur_db.insert_data(release_inf,Release,['release_id'])
+    string_fields = ["release_name", "release_description", "release_author", "release_tag_name"]
+    augur_db.insert_data(release_inf,Release,['release_id'], string_fields=string_fields)
 
     logger.info(f"Inserted info for {owner}/{repo_id}/{release['name']}\n")
 

augur/tasks/util/worker_util.py

@@ -138,7 +138,7 @@ def parse_json_from_subprocess_call(logger, subprocess_arr, cwd=None):
     try:
         required_output = json.loads(output)
     except json.decoder.JSONDecodeError as e:
-        session.logger.error(f"Could not parse required output! \n output: {output} \n Error: {e}")
+        logger.error(f"Could not parse required output! \n output: {output} \n Error: {e}")
         raise e
 
     return required_output