docker compose mounts volume for postgres by default #2677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
volume
support for postgresqlpython3-pip
dependency in dockerfile topython3-dev
(explanation below)This PR fixes #2676
Notes for Reviewers
The first file, the
compose
file, should be simple to follow with knowledge ofvolumes
in docker. But why did I change theDockerfile
, you may wonder?I've included a very-unrelated change from the original title and intent of this PR. I found this lil' nugget when I went to test my changes
Output would occur whenever I built the dockerfile to run with
docker compose
, or when I built the file by itself. With a bit of sleuthing (ddg-ing) I found the littleist jupyterhub reported similar issues. In our case, using deban/buster, includingpython3-dev
solved the issue. Let me know if you'd like this to be included somehow else, or if I've busted something else in the attempt to fix the issue.Signed commits