Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for update_field_names methods #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenkolawole
Copy link

Test_format.py was missing coverage for lines 72 - 76. This commit fixes that.

Signed-off-by: stevekola [email protected]

@stevenkolawole
Copy link
Author

stevenkolawole commented Apr 13, 2021

The test is failing because of this line:

data.rename(columns={key: matching[key]})

The inplace=True argument wasn't specified in the rename function, hence the field names were only changed temporarily.

Should I create a PR/issue to fix this?

cc: @sduenas @vchrombie

@stevenkolawole
Copy link
Author

Hello,

So I've fixed the issue of why this test is failing. #37

Test_format.py was missing coverage for lines 72 - 76.
This commit fixes that.

Signed-off-by: stevekola <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant