Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Mobile UI of dashboard #524

Open
wants to merge 1 commit into
base: muggle
Choose a base branch
from

Conversation

SourabhSaraswat-191939
Copy link
Contributor

This commit improves the Mobile UI of Dashboard
It Includes fixes of content Overflowing out of boxes
in Mobile UI.

@SourabhSaraswat-191939
Copy link
Contributor Author

Mobile UI Before Changes

Screenshot 1943-01-23 at 11 43 31 PM

Mobile UI After Changes

Screenshot 1943-01-24 at 12 30 51 PM

Screenshot 1943-01-24 at 12 30 54 PM

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. Do you mind to create a commit as suggested in the contributing rules?

@SourabhSaraswat-191939
Copy link
Contributor Author

Sure @sduenas,
As I don't know about Changelog Entries. So first I read about it and then I will do this soon.

@SourabhSaraswat-191939
Copy link
Contributor Author

Sorry for the late response due to some work.

@sduenas, I think I did something bad which I should not do.
I was trying to squash my commit and add a description, but i did something wrong due to which that much commits are added in this PR.

Please help me in solving this.

@vchrombie
Copy link
Member

Hi @SourabhSaraswat-191939

Can you try to rebase with the upstream and force push the branch?

$ git fetch upstream
$ git rebase upstream/muggle
$ git push -f origin muggle

Let us know if it worked.

@SourabhSaraswat-191939 SourabhSaraswat-191939 force-pushed the muggle branch 2 times, most recently from 0d3fa3e to 3c9d351 Compare April 20, 2021 14:15
@SourabhSaraswat-191939
Copy link
Contributor Author

Thank You @vchrombie, yes it works for me.

I did some improvement in my commit.
If any other changes required then please let me know.

@vchrombie
Copy link
Member

Hi @SourabhSaraswat-191939
It would be great if you can follow the commit message guidelines.
https://github.com/chaoss/grimoirelab/blob/master/CONTRIBUTING.md#guidelines-to-follow-to-write-good-commit-messages

Let us know if you need any help.

@SourabhSaraswat-191939 SourabhSaraswat-191939 force-pushed the muggle branch 2 times, most recently from fa02b2e to 2183a5d Compare April 24, 2021 19:25
@SourabhSaraswat-191939
Copy link
Contributor Author

It would be great if you can follow the commit message guidelines.
https://github.com/chaoss/grimoirelab/blob/master/CONTRIBUTING.md#guidelines-to-follow-to-write-good-commit-messages

@vchrombie, I did some changes. Please check it and let me know if there any improvement required.

@vchrombie
Copy link
Member

vchrombie commented Apr 28, 2021

Hi @SourabhSaraswat-191939, sorry but the commit message is still not proper. It would be great if you can change the commit message to this

[ui] Improve the mobile view of the dashboard

This commit improves the mobile UI of sortinghat
dashboard. It fixes the issues of the content overflowing.

Thanks.

This commit improves the mobile UI of sortinghat
dashboard. It fixes the issues of the content overflowing.

Signed-off-by: Sourabh Saraswat <[email protected]>
@SourabhSaraswat-191939
Copy link
Contributor Author

It would be great if you can change the commit message to this

@vchrombie , Done 👍🏻

@SourabhSaraswat-191939
Copy link
Contributor Author

@sduenas @vchrombie, Is there any updates needed in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants