Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Skip recommendation #939

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

evamillan
Copy link
Contributor

This PR adds a button on the "Review recommendations" modal to skip the current recommendation and load the next one.
Fixes #937.

@evamillan evamillan force-pushed the skip-recommendation branch 2 times, most recently from dec31e1 to 044bd51 Compare November 21, 2024 08:57
Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks ok but when there's only one recommendation or it's the last recommendation, the Skip button doesn't show. In those cases, the button should be there but once is clicked, the modal hides.

Copy link
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adds a button on the Review recommendations modal
to skip the current recommendation and load the
next one.

Signed-off-by: Eva Millán <[email protected]>
@sduenas sduenas force-pushed the skip-recommendation branch from 03cb585 to 4570a03 Compare November 21, 2024 15:21
@sduenas sduenas merged commit b40492f into chaoss:master Nov 21, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Recommendations: Skip option
2 participants