Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update screenshots #223

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: update screenshots #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f1e9a
fix: update screenshot
CBID2 Sep 14, 2023
c21e286
feat: replace old screenshot with new one
CBID2 Sep 15, 2023
be0736c
fix: replace screenshot in Developer installation tutorial
CBID2 Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified docs/getting-started/assets/dashboard.png
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are your thoughts on preserving the size of the image when updating? I haven't checked where the image appears in the tutorial and whether a larger size will effect the display in the tutorial.

The original screenshot did not have the red and blue boxes painted on it - I suggest not adding them in the updated screenshots.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added docs/getting-started/assets/filter.png
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the new file is different from the old file. When changing file names, the references in the document also need to be updated. It may be easier to keep the same file name

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed docs/getting-started/assets/filters.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion docs/getting-started/dev-setup.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new image does not show for me.

Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ Optionally, you can create a configuration in PyCharm to speed up the executions

The final results should be something similar to the image below.

![result](https://user-images.githubusercontent.com/25265451/84477839-ee90ad00-acad-11ea-932f-cc7ce81e05a7.png)
![result](https://user-images.githubusercontent.com/1056838b3b04d6-36e6-4469-aa42-0d4895d74e79.png)

## Only docker

Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started/troubleshooting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ parent: Getting Started
# Troubleshooting

> Please check this page if you face any problem with setting up GrimoireLab. If
> you didn't find the solution for your proble, please open an [issue in the
> you didn't find the solution for your problem, please open an [issue in the
> chaoss/grimoirelab repository](https://github.com/chaoss/grimoirelab/issues).
> If you found out the reason, and would like to add it to this section, please
> feel free to open a [pull request to the chaoss/grimoirelab-tutorial
Expand Down