-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeBuild RDS Flyway example #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd split this into two CloudFormation templates: one to create the VPC, and one to create the database and CodeBuild. That way, if people already have a VPC that's set up with private/public subnets, they can just use it.
Your deploy.sh
can wait for the first stack to complete -- take a look at the deployment script in the "two buckets" example. And you can grab the outputs from one script and automatically set them on the other.
With that said, if you're looking to get this published, then one CF template is fine.
- "logs:CreateLogGroup" | ||
- "logs:CreateLogStream" | ||
- "logs:PutLogEvents" | ||
Resource: "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much prefer creating the log group explicitly, then allowing CreateLogStream
and PutLogEvents
with the group's ARN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I do this in another PR?
EngineVersion: "11.13" | ||
EngineMode: "serverless" | ||
# NEVER LEAVE THIS ON IN PRODUCTION | ||
EnableHttpEndpoint: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed this; is it something that you need for the example, or can you set to false
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I set it so they can explore the example. I didn't get into any detail beyond this comment. But maybe I need some more text in the blog about why it's set and what they can do with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migrated to Serverless V2 Postgres 14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And removed the EnableHttpEndpoint - not relevant in Serverless Aurora V2
Added example in rds-flyway-migrations that:
env
>secrets-manager
property to encrypt the secrets pulled from the Secrets Manager service in the CodeBuild project