Fix for #519 - add support for HGVS repeats #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a stab at implementing support for repeats as documented at https://varnomen.hgvs.org/recommendations/DNA/variant/repeated/.
I hope the new class names sufficiently aligns with what you expect.
I considered renaming the
NucleotideShortSequenceRepeatVariability
over toLegacyNucleotideShortSequenceRepeatVariability
but figured this would be a breaking change. I'm not sure how you want to distinguish between the current spec and the old spec at https://www.hgvs.org/mutnomen/.