Port plotReverseCumulatives to ggplot2 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this, TagCluster objects receive a copy of the parent object's colData. Also fix check NOTEs related to ggplot2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely replaces
plotReverseCumulativeswith an alternative based on ggplot2. This allows for further customization by adding layers, modifying axes, etc., and may be extended later to broaden the faceting capabilities. The new function is backwards-incompatible with the previous one because the argumentsxlim,ylim,xlab,xlab,main,legend, andonePlothave been dropped since ggplot2 now allows a posteriori customisation.Here is a comparison of the outputs:
And here are examples using facetting and customisation.