Improve show detail and close detail performance.

charles7668 · Dec 14, 2024 · 6a7995f · 6a7995f
1 parent aa60e12
commit 6a7995f
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 18 deletions.
diff --git a/GameManager/Components/Pages/Home.Razor.cs b/GameManager/Components/Pages/Home.Razor.cs
@@ -491,22 +491,18 @@ private Task OnShowDetail(int id)
         {
             IsShowDetail = true;
             _showDetailId = id;
-            _ = InvokeAsync(StateHasChanged);
             return Task.CompletedTask;
         }
 
         private async Task OnCloseDetail()
         {
-            IsShowDetail = false;
-            await JsRuntime.InvokeVoidAsync("enableHtmlOverflow");
             GameInfoDTO? updateItem = await ConfigService.GetGameInfoBaseDTOAsync(_showDetailId);
             ViewInfo? viewInfo = ViewGameInfos.Find(x => x.Info.Id == _showDetailId);
             if (updateItem != null && viewInfo != null)
             {
                 viewInfo.Info = updateItem;
             }
-
-            _ = InvokeAsync(StateHasChanged);
+            IsShowDetail = false;
         }
 
         private async Task OnEnableSyncClick()

diff --git a/GameManager/Components/Pages/components/GameDetail.razor.cs b/GameManager/Components/Pages/components/GameDetail.razor.cs
@@ -98,7 +98,6 @@ private Task RefreshData(GameInfoDTO? inputGameInfo = null)
                 try
                 {
                     Logger.LogInformation("start loading game info");
-                    _ = JsRuntime.InvokeVoidAsync("disableHtmlOverflow");
                     GameInfoDTO gameInfo = inputGameInfo ??
                                            await ConfigService.GetGameInfoDTOAsync(x => x.Id == InitGameId,
                                                q => q.Include(x => x.LaunchOption)) ??

diff --git a/GameManager/wwwroot/js/webview_api.js b/GameManager/wwwroot/js/webview_api.js
@@ -33,16 +33,4 @@ function getCardListWidth() {
 
 function remToPixels(rem) {
     return rem * parseFloat(getComputedStyle(document.documentElement).fontSize);
-}
-
-function disableHtmlOverflow(){
-    window.scrollTo({
-        top: 0,
-        behavior: 'instant'
-    })
-    document.querySelector("html").classList.add("overflow-y-hidden");
-}
-
-function enableHtmlOverflow(){
-    document.querySelector("html").classList.remove("overflow-y-hidden");
 }