chore: split YamlReadingTest into several files #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @OptimumCode. Could you please split this PR into smaller PRs, or at least multiple commits? That will make it easier to review and also help manage conflicts with other inflight PRs that might merge first. |
|
Hi, @charleskorn. Sure, will it be okay to convert it into a separate PR per new file (each based on the previous one)? Should be 8 PRs if I count correctly |
Perfect, thanks. |
charleskorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @charleskorn. This PR should resolve #27.
Please let me know if you have any comments/suggestions/objections regarding how I split the test.
Also, I think the tests can be grouped in the
readingpackage - it will make it easier to navigate in the project, I think. What do you think about that?