Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manifests for CSI to 3.3.1 and CPI to 1.31 #32

Closed
wants to merge 3 commits into from

Conversation

jblesener
Copy link

Looks like the manifests haven't been updated in some time and the charm doesn't have the versions for the currently supported versions of Charmed Kubernetes (1.31, 1.30, 1.29). Additionally, VMware recommends CSI version 3.3.0+ for use with vSphere 8.0 Update 3.

CPI compat: https://github.com/kubernetes/cloud-provider-vsphere/blob/master/README.md#compatibility-with-kubernetes
CSI compat: https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/3.0/vmware-vsphere-csp-getting-started/GUID-D4AAD99E-9128-40CE-B89C-AD451DA8379D.html

@addyess
Copy link
Member

addyess commented Sep 25, 2024

@jblesener thanks so much for this PR

could you also update .github/workflows/ci.yaml

-    uses: canonical-web-and-design/Inclusive-naming/.github/workflows/woke.yaml@main
+    uses: canonical/inclusive-naming/.github/workflows/woke.yaml@main

@jblesener
Copy link
Author

@addyess sure, all set!

@addyess
Copy link
Member

addyess commented Oct 7, 2024

@jblesener i don't ACTUALLY have access to a vsphere environment at the moment to test this. Do you?

@jblesener
Copy link
Author

@addyess I do have some vsphere environments I can test on. I had some trouble building the charm using charmcraft earlier but was able to figure it out. Applying the updated charm results in stuck Deployment/DaemonSet since it can't pull images from rocks.canonical.com (ex: rocks.canonical.com:443/cdk/sig-storage/csi-attacher:v4.5.1). Is there a process to get those images mirrored? These are the images the updated manifests use (some might also be used in the older manifests):

gcr.io/cloud-provider-vsphere/cpi/release/manager:v1.2.1
gcr.io/cloud-provider-vsphere/cpi/release/manager:v1.27.0
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.0.2
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.0.3
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.1.0
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.1.1
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.1.2
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.2.0
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.3.0
gcr.io/cloud-provider-vsphere/csi/release/driver:v3.3.1
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.0.2
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.0.3
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.1.0
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.1.1
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.1.2
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.2.0
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.3.0
gcr.io/cloud-provider-vsphere/csi/release/syncer:v3.3.1
k8s.gcr.io/sig-storage/csi-attacher:v4.2.0
k8s.gcr.io/sig-storage/csi-node-driver-registrar:v2.7.0
k8s.gcr.io/sig-storage/csi-provisioner:v3.4.0
k8s.gcr.io/sig-storage/csi-resizer:v1.7.0
k8s.gcr.io/sig-storage/csi-snapshotter:v6.2.1
k8s.gcr.io/sig-storage/livenessprobe:v2.9.0
registry.k8s.io/cloud-pv-vsphere/cloud-provider-vsphere:v1.28.0
registry.k8s.io/cloud-pv-vsphere/cloud-provider-vsphere:v1.29.0
registry.k8s.io/cloud-pv-vsphere/cloud-provider-vsphere:v1.30.1
registry.k8s.io/cloud-pv-vsphere/cloud-provider-vsphere:v1.31.0
registry.k8s.io/sig-storage/csi-attacher:v4.3.0
registry.k8s.io/sig-storage/csi-attacher:v4.5.0
registry.k8s.io/sig-storage/csi-attacher:v4.5.1
registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.10.0
registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.10.1
registry.k8s.io/sig-storage/csi-node-driver-registrar:v2.8.0
registry.k8s.io/sig-storage/csi-provisioner:v3.5.0
registry.k8s.io/sig-storage/csi-provisioner:v4.0.0
registry.k8s.io/sig-storage/csi-provisioner:v4.0.1
registry.k8s.io/sig-storage/csi-resizer:v1.10.0
registry.k8s.io/sig-storage/csi-resizer:v1.10.1
registry.k8s.io/sig-storage/csi-resizer:v1.8.0
registry.k8s.io/sig-storage/csi-snapshotter:v6.2.2
registry.k8s.io/sig-storage/csi-snapshotter:v7.0.1
registry.k8s.io/sig-storage/csi-snapshotter:v7.0.2
registry.k8s.io/sig-storage/livenessprobe:v2.10.0
registry.k8s.io/sig-storage/livenessprobe:v2.12.0

@addyess
Copy link
Member

addyess commented Oct 7, 2024

@jblesener I can try to sync the images to rocks.cc if that helps

@addyess
Copy link
Member

addyess commented Oct 7, 2024

@jblesener i just saw this issue:
kubernetes/cloud-provider-vsphere#1251

It may be some of these images from prior releases cannot be found. I'll try to mirror what i can to rocks.cc

@jblesener
Copy link
Author

@addyess It looks like VMware is republishing some images from the last few releases. I'm not sure if they have plans to fully backfill the missing images.
kubernetes-sigs/vsphere-csi-driver#3054 (comment)
kubernetes-sigs/vsphere-csi-driver#3053 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants