add candlestick dataset options types #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #114
Adding custom
CandlestickControllerDatasetOptions
typings to replace use ofBarControllerDatasetOptions
to allow for uniqueborderColor
type:This will allow the configuration of bar color properties in Typescript/Angular sites where typings are needed. For example:
Additional comments
I'm not a JS expert, so please treat this as a suggestion. There may be a better way to handle it. This approach seems to be a bit of a hack. I have two other suggestions here:
Make this the default so you'd only need to provide
borderColor
if you wanted a consistently colored border.Allow use of
backgroundColor
in a similar up/down/unchanged format. OverridingChart.defaults.elements["candlestick"]
as shown in my example (above) is less intuitive.