-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to chartjs v4 and fix bugs #170
Conversation
1ed5ede
to
0e49e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's really no way to review this with code changes and formatting changes mixed together. it probably would have been better to do the reformatting as a separate PR from the actual changes
# Replace stock eslint rules with typescript-eslint equivalents for proper | ||
# TypeScript support. | ||
indent: "off" | ||
"@typescript-eslint/indent": ["error", 2] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's a mix of formatting in this file. this rule is surrounded by double quotes and it's single quotes two lines below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copied from parent project: https://github.com/chartjs/Chart.js/blob/master/.eslintrc.yml 🤷
819465c
to
37ffa27
Compare
Co-authored-by: Ben McCann <[email protected]>
agreed, I jumped the gun a bit here, in the spirit of expediting alignment with the parent project. |
I'll leave it up to you then. Go ahead and merge if you feel confident enough in it. I don't think there's much help I can provide from looking at the diff |
Sounds good, will add a bit more information about the changes in the README.md and then merge/release. |
Thanks for contributing.
Description
Upgraded the library to work with Chart.js v4. Change of configuration APIs was needed in order to avoid Chart.js errors.
Improved the testing examples in docs to showcase improved animations, color defaults matching the default Chart.js theme, updated code style, linting and packaging to match Chart.js standards.
Testing
Check docs/index.html