Welcome e2e tests #1092
Welcome e2e tests #1092
Conversation
|
@boodland is attempting to deploy a commit to the Chayn Team on Vercel. A member of the Team first needs to authorize it. |
|
@kyleecodes a follow up issue/ticket can be created to add tests for the rest of languages and partners (bumble and fruitz), I did not include all of them to save time and be able to move to another migration task, also they can be good first tasks for new contributors. Thanks in advance |
| cy.get('button').contains('Get started').click(); | ||
| cy.checkPageUrl(registerPartnerBadooUrl); | ||
| }); | ||
| it('with action code', () => { |
There was a problem hiding this comment.
So i'd drop this test with action code. I think this test can be very minimal. We also have other tests that loosely follow the same flow so this doesn't need to be thorough. See register-partner-with-code.tsx and register-partner-without-code.tsx. Also you might have a different setup as this didn't work for me.
There was a problem hiding this comment.
@eleanorreem I have applied the changes.Thanks for the feedback!
|
@boodland thanks for this! Nice to safeguard your changes. I think you might be duplicating some cypress tests so I'd keep this test a bit simpler. See create-user.tsx, register-partner-with-code.tsx and register-partner-without-code.tsx. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks @boodland |
Bloom frontend
|
||||||||||||||||||||||||||||||
| Project |
Bloom frontend
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 07m 14s |
| Commit |
|
| Committer | Alberto Arias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
40
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Tests for review
Issue link / number:
#1089
What changes did you make?
Created welcome and welcome badoo e2e tests for english version
Why did you make the changes?
So the page is covered with test and help us to validate it is working when making changes or migrating it to app router
Did you run tests?
Yes