Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixtures Guide #1160

Merged
merged 14 commits into from
Jan 17, 2025
Merged

Fixtures Guide #1160

merged 14 commits into from
Jan 17, 2025

Conversation

serverless-mom
Copy link
Contributor

@serverless-mom serverless-mom commented Jan 2, 2025

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

@serverless-mom serverless-mom requested a review from tnolet as a code owner January 2, 2025 21:11
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 8:04pm

@serverless-mom
Copy link
Contributor Author

If y'all have a ton of revisions for the guide, let me know and we can move it back to Notion! Due to the code moving about it was easier for me to work directly in Markdown, but I can gladly move back there for revisions

Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make all the example code ts. I added some suggestions but it's probably better to do it in one commit.

site/content/guides/developer-fixtures.md Outdated Show resolved Hide resolved
site/content/guides/developer-fixtures.md Outdated Show resolved Hide resolved
site/content/guides/developer-fixtures.md Outdated Show resolved Hide resolved
site/content/guides/developer-fixtures.md Outdated Show resolved Hide resolved
site/content/guides/developer-fixtures.md Outdated Show resolved Hide resolved
site/content/learn/playwright/test-fixtures.md Outdated Show resolved Hide resolved
@serverless-mom
Copy link
Contributor Author

@tnolet Tags are updated! Also I finally found the gosh-darned linter setting that was automatically setting my code blocks to be js

@tnolet tnolet self-requested a review January 15, 2025 09:30
Copy link
Member

@tnolet tnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serverless-mom serverless-mom merged commit f9d5a9f into main Jan 17, 2025
6 checks passed
@serverless-mom serverless-mom deleted the fixtures branch January 17, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants