Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ToC on the guides section #914

Merged
merged 7 commits into from
Oct 10, 2023
Merged

feat: add ToC on the guides section #914

merged 7 commits into from
Oct 10, 2023

Conversation

pilimartinez
Copy link
Member

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

Add ToC on guides section

Screenshots

image

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #17693: Add Table of contents to the guides section.

@vercel
Copy link

vercel bot commented Sep 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 0:49am

@pilimartinez pilimartinez removed the request for review from tnolet September 14, 2023 13:52
@vercel vercel bot temporarily deployed to staging September 14, 2023 13:53 Inactive
@vercel vercel bot temporarily deployed to staging September 14, 2023 16:00 Inactive
@stefanjudis
Copy link
Collaborator

@pilimartinez There's a container missing that limits the overall width. 🫣

image

@pilimartinez
Copy link
Member Author

@pilimartinez There's a container missing that limits the overall width. 🫣

image

Should be fixed now 👍

@vercel vercel bot temporarily deployed to staging September 18, 2023 09:18 Inactive
stefanjudis
stefanjudis requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@stefanjudis stefanjudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have the same "sticky" behavior we have in the docs?

image

In the docs the TOC tables sticks on the top when scrolling?

@vercel vercel bot temporarily deployed to staging September 18, 2023 12:55 Inactive
stefanjudis
stefanjudis requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@stefanjudis stefanjudis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that looks like different behavior. Could we have the same sidebar behavior?

sticky.mp4

Happy to wrangle it together and help. :)

@vercel vercel bot temporarily deployed to staging September 29, 2023 10:47 Inactive
@stefanjudis stefanjudis enabled auto-merge (squash) October 10, 2023 12:47
@stefanjudis stefanjudis merged commit c402b72 into main Oct 10, 2023
4 checks passed
@stefanjudis stefanjudis deleted the pilarmartinez/sc-17693/add-table-of-contents-to-the-guides-section branch October 10, 2023 12:49
@vercel vercel bot temporarily deployed to staging October 10, 2023 12:49 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanjudis stefanjudis stefanjudis approved these changes

Assignees

@pilimartinez pilimartinez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pilimartinez @stefanjudis