Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds first snapshot docs [sc-00] #934

Merged
merged 4 commits into from
Nov 9, 2023
Merged

docs: adds first snapshot docs [sc-00] #934

merged 4 commits into from
Nov 9, 2023

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Nov 8, 2023 •
edited
Loading

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

  • adds docs for snapshot testing
  • updates command line reference
  • adds a test that does visual comparison

New Dependency Submission

  • uses are CLI pre-release. Will be replaced with actual release

Screenshots

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 9:50am

@tnolet tnolet marked this pull request as ready for review November 8, 2023 16:37
clample
clample approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@clample clample left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 👍

I like the videos, they make things more clear.

@tnolet tnolet merged commit 6178681 into main Nov 9, 2023
5 checks passed
@tnolet tnolet deleted the tnolet/snapshot-docs branch November 9, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clample clample clample approved these changes

@ragog ragog Awaiting requested review from ragog

@modern-sapien modern-sapien Awaiting requested review from modern-sapien

@checklyalex checklyalex Awaiting requested review from checklyalex

Assignees

@tnolet tnolet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tnolet @clample