Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tnolet/various fixes sc00 #942

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Tnolet/various fixes sc00 #942

merged 4 commits into from
Nov 22, 2023

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Nov 21, 2023

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Notes for the Reviewer

  • updates and centralizes runtime variables.
  • updates and centralizes file system and upload/download usage in Browser and Multistep.
  • updates icons.
  • small code fixes.

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 3:54pm

@tnolet tnolet requested a review from stefanjudis November 21, 2023 15:50
@tnolet
Copy link
Member Author

tnolet commented Nov 21, 2023

@modern-sapien this includes a tweaked (and even simpler) version of the upload/download behaviour we were digging into

@tnolet tnolet merged commit c5107d5 into main Nov 22, 2023
5 checks passed
@tnolet tnolet deleted the tnolet/various-fixes-sc00 branch November 22, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants