Implement key decoding strategy alteration capability

checkout · Aug 8, 2024 · 639ba0b · 639ba0b
1 parent 53f91a4
commit 639ba0b
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/verify-pr.yml b/.github/workflows/verify-pr.yml
@@ -14,7 +14,7 @@ concurrency:
 jobs:
   lint:
     name: SwiftLint
-    runs-on: macos-latest
+    runs-on: macos-13-large
 
     steps:
       - name: Checkout

diff --git a/Sources/CheckoutNetwork/CheckoutNetworkClient.swift b/Sources/CheckoutNetwork/CheckoutNetworkClient.swift
@@ -47,7 +47,10 @@ public class CheckoutNetworkClient: CheckoutClientInterface {
                 }
 
                 do {
-                    let dataResponse = try JSONDecoder().decode(T.self, from: data)
+                    let decoder = JSONDecoder()
+                    decoder.keyDecodingStrategy = configuration.decodingStrategy
+                    let dataResponse = try decoder.decode(T.self, from: data)
+
                     completionHandler(.success(dataResponse))
                 } catch {
                     completionHandler(.failure(error))

diff --git a/Sources/CheckoutNetwork/ConfigurationModels/RequestConfiguration.swift b/Sources/CheckoutNetwork/ConfigurationModels/RequestConfiguration.swift
@@ -12,6 +12,7 @@ public struct RequestConfiguration {
 
     /// Request created from the consumers configuration
     private(set) public var request: URLRequest
+    var decodingStrategy: JSONDecoder.KeyDecodingStrategy
 
     /// Create request configuration with provided parameters. In case of failure will throw a `CheckoutNetworkError`
     ///
@@ -26,7 +27,8 @@ public struct RequestConfiguration {
                 queryItems: [String: String] = [:],
                 customHeaders: [String: String] = [:],
                 bodyData: Data? = nil,
-                mimeType: MIMEType = .JSON) throws {
+                mimeType: MIMEType = .JSON,
+                decodingStrategy: JSONDecoder.KeyDecodingStrategy = .useDefaultKeys) throws {
         // Validate URL can be broken down to components for formatting
         guard var components = URLComponents(url: path.url(), resolvingAgainstBaseURL: true) else {
             throw CheckoutNetworkError.invalidURL
@@ -54,7 +56,8 @@ public struct RequestConfiguration {
             request.addValue(mimeType.rawValue, forHTTPHeaderField: MIMEType.key)
         }
         customHeaders.forEach { request.addValue($0.value, forHTTPHeaderField: $0.key) }
-
+
+        self.decodingStrategy = decodingStrategy
         self.request = request
     }