Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how Frames options are sent to Risk SDK #530

Conversation

precious-ossai-cko
Copy link
Contributor

Issue

https://checkout.atlassian.net/browse/PRISM-11216

Proposed changes

  • Updates the Risk SDK version to 3.0.0 which adds correlationID as a metadata instead of a direct event arguement which also changes the structure of receiving the frames options collecting more data(product name, version and correlationID) to improve the log tracing.
  • Moves Risk config and initialisation after the log manager initialisation since the setup method calls a resetCorrelationID method which updates the correlationID.

Test Steps

No internal changes made.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Reviewers assigned
  • I have performed a self-review of my code and manual testing
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if applicable)

@okhan-okbay-cko okhan-okbay-cko force-pushed the fix/update-how-frames-options-are-sent-to-risk-sdk branch from c73d6bb to b7e60bd Compare April 25, 2024 15:31
@okhan-okbay-cko okhan-okbay-cko marked this pull request as ready for review April 25, 2024 15:31
@okhan-okbay-cko okhan-okbay-cko force-pushed the fix/update-how-frames-options-are-sent-to-risk-sdk branch from b7e60bd to f2d5b45 Compare April 25, 2024 15:35
@okhan-okbay-cko okhan-okbay-cko changed the base branch from main to release/4.3.5 April 25, 2024 15:48
@okhan-okbay-cko okhan-okbay-cko changed the title Fix: update how frames options are sent to risk SDK Update how Frames options are sent to risk SDK Apr 25, 2024
@okhan-okbay-cko okhan-okbay-cko changed the title Update how Frames options are sent to risk SDK Update how Frames options are sent to Risk SDK Apr 25, 2024
@okhan-okbay-cko okhan-okbay-cko merged commit 7e1309c into release/4.3.5 Apr 30, 2024
7 checks passed
@okhan-okbay-cko okhan-okbay-cko deleted the fix/update-how-frames-options-are-sent-to-risk-sdk branch April 30, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants