Implement timeout for Risk SDK #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhan-okbay-cko
force-pushed
the
feature/risk-sdk-timeout-recovery
branch
from
6146607
to
ce36255
Compare
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
GitHub Actions
Inactive
ehab-al-cko
reviewed
Aug 5, 2024
ehab-al-cko
previously approved these changes
Aug 5, 2024
okhan-okbay-cko
force-pushed
the
feature/risk-sdk-timeout-recovery
branch
from
ce36255
to
782d6ae
Compare
okhan-okbay-cko
force-pushed
the
feature/risk-sdk-timeout-recovery
branch
2 times, most recently
from
d2e063a
to
45dd3da
Compare
okhan-okbay-cko
added
Run Regression Tests
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
GitHub Actions
Inactive
ehab-al-cko
previously approved these changes
Aug 5, 2024
precious-ossai-cko
previously approved these changes
Aug 5, 2024
okhan-okbay-cko
dismissed stale reviews from precious-ossai-cko and ehab-al-cko
The base branch was changed.
okhan-okbay-cko
force-pushed
the
feature/risk-sdk-timeout-recovery
branch
2 times, most recently
from
d262c9a
to
8060c40
Compare
okhan-okbay-cko
added
Run Regression Tests
Validate For App Store
and removed
Run Regression Tests
Validate For App Store
labels
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
GitHub Actions
Inactive
okhan-okbay-cko
force-pushed
the
feature/risk-sdk-timeout-recovery
branch
from
8060c40
to
7743d72
Compare
okhan-okbay-cko
temporarily deployed
to
AppStoreValidation
GitHub Actions
Inactive
ehab-al-cko
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PIMOB-2696
Unblocks #542
Proposed changes
Risk team had a development that made Frames’s completion block to await their completion. This ended up with some merchants getting blocked by the response of Risk SDK. We had a long chat and decided the issue is because of another 3rd party dependency that the Risk SDK uses: FingerPrint SDK. Now we agreed with the Risk team to have a Frames development to timeout after a definitive timeframe to stop waiting for Risk SDK result and just call the callback with the token that’s already at hand.
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.