Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PhoneNumberKit to 3.8.0 - Fixes Swift 6 Builds #547

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dimitryvin
Copy link

Issue

Swift 6 Builds fail

Fix

PhoneNumberKit made a release last week fixing builds in Swift 6 as per the change log here: https://github.com/marmelroy/PhoneNumberKit/releases/tag/3.8.0

This PR updates the Package.swift as well as the Package.resolved.

@dimitryvin
Copy link
Author

@okhan-okbay-cko Would love to get this in when possible! Thank you!

@okhan-okbay-cko
Copy link
Contributor

@okhan-okbay-cko Would love to get this in when possible! Thank you!

hey @dimitryvin, would it work if you use the forked repository of yours?

@dimitryvin
Copy link
Author

@okhan-okbay-cko Would love to get this in when possible! Thank you!

hey @dimitryvin, would it work if you use the forked repository of yours?

I can definitely use the fork in meantime. Are you planning on making this update when Swift 6 + Xcode 16 are out?

@okhan-okbay-cko
Copy link
Contributor

hey @dimitryvin, thanks for confirming that targeting a forked repository will work for you in this case.

We're not planning any releases soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants