dependency: bump com.google.errorprone:error_prone_core from 2.31.0 to 2.36.0

[dependabot]

Bumps com.google.errorprone:error_prone_core from 2.31.0 to 2.36.0.

Release notes

Sourced from com.google.errorprone:error_prone_core's releases.

Error Prone 2.36.0

Changes:

• Add new matcher interfaces to ErrorProneScanner for AST nodes introduced after Java 11 (e5fd194fa21ef9a01e8d4c72489906247aad81c8)
• Fix compatibility with latest JDK 24 EA builds (google/error-prone@d67bc15)
• Check that --should-stop=ifError=FLOW is set when using the -Xplugin integration (e71db1f369a9367f6f2db34c4fbd006b6d6238fd)

New checks:

• DuplicateBranches: Discourage conditional expressions and if statements where both branches are the same
• RedundantControlFlow: Reports redundant continue statements.

Closed issues: #4633, #4646

Error Prone 2.35.1

Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release.

Version 3.25.5 of protobuf still fixes CVE-2024-7254. This release is provided for users who aren't ready to update to 4.x, see also #4584 and #4634. Future versions of Error Prone will upgrade back to protobuf 4.x.

Full changelog: google/error-prone@v2.35.0...v2.35.1

Error Prone 2.35.0

Changes:

• Fix handling of \s before the trailing delimiter in MisleadingEscapedSpace
• TimeUnitMismatch improvements: handle binary trees, consider trees like fooSeconds * 1000 to have units of millis

New checks:

• JavaDurationGetSecondsToToSeconds: Prefer duration.toSeconds() over duration.getSeconds()

Full changelog: google/error-prone@v2.34.0...v2.35.0

Error Prone 2.34.0

Changes:

• Passing the javac flag --should-stop=ifError=FLOW is now required when running Error Prone (#4595)
• The MemberName check was renamed to IdentifierName

New checks:

• FutureTransformAsync: The usage of transformAsync is not necessary when all the return values of the transformation function are immediate futures.
• MisformattedTestData: Reformats Java source code inside Error Prone test cases.
• MisleadingEscapedSpace: Using \s anywhere except at the end of a line in a text block is potentially misleading.
• ThrowIfUncheckedKnownUnchecked: throwIfUnchecked(knownUnchecked) is equivalent to throw knownUnchecked.

Closed issues: #4595, #4598, #4620

Full changelog: google/error-prone@v2.33.0...v2.34.0

... (truncated)

Commits

• ab522c7 Release Error Prone 2.36.0
• fc5aade Remove swathes of assume()s on the current runtime version.
• b222ea8 Handle qualified enum elements in MissingCasesInEnumSwitch.
• 332cbfa Support record destructuring in ArgumentSelectionDefectChecker.
• 0db3360 UsafeLocaleUsage: update the proposed fix to use replace(char, char)
• c816c8b StatementSwitchToExpressionSwitch - remove // fall out comments in switches
• b5fa441 Consolidate javadoc plugin version
• 2afd0cf Run StatementSwitchToExpressionSwitch_refactoring over EP.
• 37895d3 Fix snapshot doc publishing after https://github.com/google/error-prone/commi...
• c438756 StatementSwitchToExpressionSwitch: for "assignment switch" and "direct conver...
• Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

[romani]

Jdk17 is required
#15784 (comment)