Module configuration editor does not open #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts 3e27bdc. Boolean expressions with side effects MUST NOT be modified in such a way that short circuit evaluation will remove the side effect. That's a ground rule for all kinds of code optimizations and transformations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts 3e27bdc. Boolean expressions with side effects MUST NOT be modified in such a way that short circuit evaluation will remove the side effect. That's a ground rule for all kinds of code optimizations and transformations.
I had to disable one of the sevntu rules, because it's wrong. You cannot move methods to the right of boolean expressions, if those methods have a side effect that changes any global state of the application.
Fixes #559.
Raised sevntu-checkstyle/sevntu.checkstyle#1025