Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify patch creation #791

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simplify patch creation #791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 23 additions & 40 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,29 @@
</environments>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<id>create-git-patch-file</id>
<phase>verify</phase>
<goals>
<goal>exec</goal>
</goals>
</execution>
</executions>
<configuration>
<executable>git</executable>
<arguments>
<argument>diff</argument>
<argument>HEAD~1</argument>
<argument>HEAD</argument>
</arguments>
<outputFile>${maven.multiModuleProjectDirectory}/show.patch</outputFile>
</configuration>
<inherited>false</inherited>
</plugin>
<plugin>
<artifactId>maven-checkstyle-plugin</artifactId>
<executions>
Expand Down Expand Up @@ -517,44 +540,4 @@
</plugins>
</pluginManagement>
</build>
<profiles>
<profile>
<id>git-patch</id>
<!-- This POM is both parent and reactor, therefore all plugins in the build section will be executed for all modules.
By checking for the existence of the README, we limit the execution of this profile to the parent only, thereby creating the patch only once.
TODO: In the long run, we should probably split parent and reactor into 2 POM files instead. -->
<activation>
<file>
<exists>README.md</exists>
</file>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<executions>
<execution>
<id>create-git-patch-file</id>
<!-- must be earlier than the phase we bind the checkstyle goal to -->
<phase>package</phase>
<goals>
<goal>exec</goal>
</goals>
</execution>
</executions>
<configuration>
<executable>git</executable>
<arguments>
<argument>diff</argument>
<argument>HEAD~1</argument>
<argument>HEAD</argument>
</arguments>
<outputFile>${maven.multiModuleProjectDirectory}/show.patch</outputFile>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Loading