Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added config entry for euroDate formatting #24

Closed
wants to merge 3 commits into from

Conversation

donjakobo
Copy link

Since the life timeline is designed to use euro date formatting by default, I added a setting to use DD/MM/YYYY or MM/DD/YYYY for formatting your dates.

@cheeaun
Copy link
Owner

cheeaun commented Dec 4, 2013

In my opinion, a better solution would be a custom date format option (with forward slashes). This basically mean we would need a datetime parser that parses MM/DD/YYYY, DD/MM/YYYY, YYYY/MM/DD, etc. A lot more work but would be better down the road.

@donjakobo
Copy link
Author

While a suitable solution, you should just follow KISS and not add more complexity.
At least in my usage of your timeline, I would stick to the same date format. Plus the parser would be confused by dates like 5/1/2013 and 2013/1/5, so sticking to a format in my opinion is best. It is your call tho.

@cheeaun
Copy link
Owner

cheeaun commented Dec 4, 2013

Hmm, considering that there're currently no requests/issues on using euro date format, I guess it's okay to keep the current format for now 😌

However, I do have plans to change the display format for the datetimes. In life.md, it may look like this 31/12/2013, but when rendered on the page, it could be 31 Dec 2013. This will be part of issue #27

@donjakobo
Copy link
Author

Umm I think you confused what I added, you have it in what is commenly known as European Date format.
Based on your code you have DD/MM/YYYY, the format in North America is always MM/DD/YYYY.

So currently by default (without my pull) you are using non american formatting for your date. Just wanted to clarify. My code adds the option to use your euro date format or NA format.

@cheeaun
Copy link
Owner

cheeaun commented Dec 4, 2013

Ah! I was confused 😄 The code is confusing to me because the value of euroDate is false by default and I use European date format by default in Life.

Anyway... for now, I think sticking to only one format would be best option :)

@donjakobo
Copy link
Author

Fair enough, I'll cancel my pull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants