Prevent downgrading to Chef-InSpec < 4 when using Chef 15 #367

teknofire · 2019-05-16T18:11:46Z

Description

The following changes are included in this PR

Prevent downgrading Chef-InSpec < 4 when using Chef 15,
Handle installing/removing inspec-core-bin gem when appropriate
Update the OS images used for testing and removes EOL ones.

Issues Resolved

Needed to handle the inspec-core-bin gem issue from #364

Check List

All tests pass. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/TESTING.MD
New functionality includes testing.
New functionality has been documented in the README if applicable
All commits have been signed for the Developer Certificate of Origin. See https://github.com/chef-cookbooks/community_cookbook_documentation/blob/master/CONTRIBUTING.MD

Chef-15 has a dependency on `train` 2.0 and when this cookbook attempts to downgrade to Inspec 3 it will replate it with a 1.x version which breaks the `chef-client` Signed-off-by: Will Fisher <[email protected]>

This adds in Ubuntu 18.04 and switches to using the dokken images that have fixes for TK testing Signed-off-by: Will Fisher <[email protected]>

Signed-off-by: Will Fisher <[email protected]>

alexpop

Thank you Will for the thorough update!

Will Fisher added 2 commits May 16, 2019 10:20

Prevent downgrading to Chef-InSpec < 4 for Chef-15

105191f

Chef-15 has a dependency on `train` 2.0 and when this cookbook attempts to downgrade to Inspec 3 it will replate it with a 1.x version which breaks the `chef-client` Signed-off-by: Will Fisher <[email protected]>

Remove EOL OS from testing and pull latest for others

c4253bb

This adds in Ubuntu 18.04 and switches to using the dokken images that have fixes for TK testing Signed-off-by: Will Fisher <[email protected]>

teknofire requested a review from a team May 16, 2019 18:11

Will Fisher added 4 commits May 16, 2019 11:16

Update name for inspec-core-bin removal

0478cce

Signed-off-by: Will Fisher <[email protected]>

use Chef-14 for testing InSpec < 4

99c9bcc

Signed-off-by: Will Fisher <[email protected]>

update where the CHEF_LICENSE is set to accepted for travis

8e9dedf

Signed-off-by: Will Fisher <[email protected]>

lock back to chef-14 by default

bfa3ab0

Signed-off-by: Will Fisher <[email protected]>

alexpop approved these changes May 17, 2019

View reviewed changes

alexpop merged commit d4e09e6 into chef-boneyard:master May 17, 2019

teknofire deleted the will/chef15_inspec_downgrade_fix branch May 23, 2019 16:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent downgrading to Chef-InSpec < 4 when using Chef 15 #367

Prevent downgrading to Chef-InSpec < 4 when using Chef 15 #367

teknofire commented May 16, 2019

alexpop left a comment

Prevent downgrading to Chef-InSpec < 4 when using Chef 15 #367

Prevent downgrading to Chef-InSpec < 4 when using Chef 15 #367

Conversation

teknofire commented May 16, 2019

Description

Issues Resolved

Check List

alexpop left a comment

Choose a reason for hiding this comment