Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dave/verify private 2 #8586

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Dave/verify private 2 #8586

merged 6 commits into from
Sep 11, 2024

Conversation

daveaugustus
Copy link
Contributor

πŸ”© Description: What code changed, and why?

⛓️ Related Resources

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: daveaugustus <[email protected]>
Copy link

netlify bot commented Sep 11, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit d4259fa
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/66e1470dca74f100082e3b9b

daveaugustus and others added 5 commits September 11, 2024 11:54
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Signed-off-by: daveaugustus <[email protected]>

Quality Gate failed Quality Gate failed

Failed conditions
3 New issues
49.2% Coverage on New Code (required β‰₯ 80%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@iamazzeez iamazzeez changed the base branch from main to license_scout_fix_2 September 11, 2024 09:45
@iamazzeez iamazzeez merged commit c172747 into license_scout_fix_2 Sep 11, 2024
9 of 13 checks passed
@iamazzeez iamazzeez deleted the dave/verify_private_2 branch September 11, 2024 09:46
iamazzeez added a commit that referenced this pull request Sep 11, 2024
* license scout uncommented

Signed-off-by: iamazzeez <[email protected]>

* license scout fix

Signed-off-by: iamazzeez <[email protected]>

* Ruby 3.0.4 with Postgres 14 segmentation fault

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* repo health fix

Signed-off-by: iamazzeez <[email protected]>

* repo health fix added exceptions for golang

Signed-off-by: iamazzeez <[email protected]>

* Dave/verify private 2 (#8586)

* modified pacnic check

Signed-off-by: daveaugustus <[email protected]>

* Update storage.go

* undefined log

Signed-off-by: daveaugustus <[email protected]>

* Test

Signed-off-by: daveaugustus <[email protected]>

* Revised the test cases

Signed-off-by: daveaugustus <[email protected]>

* Modified test log

Signed-off-by: daveaugustus <[email protected]>

---------

Signed-off-by: daveaugustus <[email protected]>
Co-authored-by: daveaugustus <[email protected]>

---------

Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Co-authored-by: Augusutus <[email protected]>
Co-authored-by: daveaugustus <[email protected]>
iamazzeez added a commit that referenced this pull request Sep 12, 2024
* license scout uncommented

Signed-off-by: iamazzeez <[email protected]>

* license scout fix

Signed-off-by: iamazzeez <[email protected]>

* Ruby 3.0.4 with Postgres 14 segmentation fault

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* lienses added

Signed-off-by: iamazzeez <[email protected]>

* repo health fix

Signed-off-by: iamazzeez <[email protected]>

* repo health fix added exceptions for golang

Signed-off-by: iamazzeez <[email protected]>

* Dave/verify private 2 (#8586)

* modified pacnic check

Signed-off-by: daveaugustus <[email protected]>

* Update storage.go

* undefined log

Signed-off-by: daveaugustus <[email protected]>

* Test

Signed-off-by: daveaugustus <[email protected]>

* Revised the test cases

Signed-off-by: daveaugustus <[email protected]>

* Modified test log

Signed-off-by: daveaugustus <[email protected]>

---------

Signed-off-by: daveaugustus <[email protected]>
Co-authored-by: daveaugustus <[email protected]>

---------

Signed-off-by: iamazzeez <[email protected]>
Signed-off-by: daveaugustus <[email protected]>
Co-authored-by: Augusutus <[email protected]>
Co-authored-by: daveaugustus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants