Adding the logic for control without results #8601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Dmaddu
requested changes
Sep 25, 2024
added 2 commits
September 25, 2024 11:26
Signed-off-by: Yashvi Jain <[email protected]>
Signed-off-by: Yashvi Jain <[email protected]>
YashviJain01
force-pushed
the
yashvi/CHEF-9601
branch
from
628ab9e
to
1eb850b
Compare
|
Signed-off-by: Yashvi Jain <[email protected]>
github-actions
bot
added
the
documentation
Signed-off-by: Yashvi Jain <[email protected]>
Dmaddu
approved these changes
Sep 25, 2024
kalroy
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Adding the logic for control without results Signed-off-by: Yashvi Jain <[email protected]> * Adding proper null check Signed-off-by: Yashvi Jain <[email protected]> * Pipeline fix Signed-off-by: Yashvi Jain <[email protected]> * Pipeline fix Signed-off-by: Yashvi Jain <[email protected]> --------- Signed-off-by: Yashvi Jain <[email protected]> Co-authored-by: Yashvi Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
The CSV was not having controls where results array was not populated. Now, thw controls are added in cvs
⛓️ Related Resources
https://progresssoftware.atlassian.net/browse/CHEF-9601
👍 Definition of Done
CSV and json have the same number of records now
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable
CSV and json file generated after the fix
2024-9-18 (1).csv
2024-9-18_new.json
Demo video after fix :- https://progresssoftware.sharepoint.com/:v:/s/ChefCoreC/EYx_gcHRnw1AthH72GeSczsBGDBS0q8LhLrx6xBC9iWQlg?e=R9DkEN